expose uri params label and message #49
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposing these params means that the lib will expose full bip21 uri parsing functionality Currently many apps have custom bip21 logic and this eliminates the need for that
Contributor
|
cACK. Awaiting cargo.toml update once we release a new payjoin-ffi. Just seeing this thanks to tracking at SatoshiPortal/bullbitcoin-mobile#504. |
Contributor
Author
|
replaced this pr based on various suggestions/updates: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #48
the dependency on payjoin-ffi should be locked to an updated version that includes this change LtbLightning/payjoin-ffi#44
that's why this is a draft pr for now
Note: locally I had to make some other changes just to get the example running, but I have omitted them here under the assumption that those changes were specific to my environment in some way
for reference here are the local changes included riverKanies#1